Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net7.0] Set Version for Windows #15240

Merged
merged 1 commit into from
May 30, 2023
Merged

[net7.0] Set Version for Windows #15240

merged 1 commit into from
May 30, 2023

Conversation

mattleibow
Copy link
Member

Description of Change

Backport of #15238

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same questions here: #15238 (comment)

Does moving the ordering around fix something?

@mattleibow
Copy link
Member Author

Moving around IS the fix. I added the '$(WindowsAppSDKWinUI)' == 'true' condition at some point - and that is only AFTER the WASDK is installed.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked a .binlog for Maui.Controls.Sample.Sandbox.csproj [net7.0-windows10.0.19041] on this PR, it seems right:

image

@rmarinho
Copy link
Member

/rebase

1 similar comment
@rmarinho
Copy link
Member

/rebase

@rmarinho rmarinho merged commit a860fa9 into net7.0 May 30, 2023
@rmarinho rmarinho deleted the backport/15238 branch May 30, 2023 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-7.0.92 Look for this fix in 7.0.92! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-7.0.92 Look for this fix in 7.0.92! platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants